GH-49444: [C++][FlightRPC][ODBC] Disable DSN default values on MacOS#49402
Merged
lidavidm merged 1 commit intoapache:mainfrom Mar 9, 2026
Merged
GH-49444: [C++][FlightRPC][ODBC] Disable DSN default values on MacOS#49402lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
Component: C++
Component: FlightRPC
CI: Extra: C++
lidavidm
approved these changes
Feb 26, 2026
github-actions
bot
added
awaiting merge
Member
|
@justing-bq this seems to be linked to a closed issue, can we link it to a fresh/open issue? |
Collaborator
lidavidm
changed the title
|
|
Collaborator
|
@lidavidm Thanks! Let me know if you have other comments for this PR |
alinaliBQ
force-pushed
the
gh-49387-macos-dsn-default
branch
from
f9848ef to
dcde0d4
Compare
Member
|
Is there an issue open for the tests timing out on Windows? |
Collaborator
alinaliBQ
force-pushed
the
gh-49387-macos-dsn-default
branch
from
dcde0d4 to
d064e87
Compare
Co-authored-by: alinalibq <alina.li@improving.com>
alinaliBQ
force-pushed
the
gh-49387-macos-dsn-default
branch
from
d064e87 to
e169614
Compare
lidavidm
approved these changes
Mar 9, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8c2d93c. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
iodbc driver manager on macOS treats default values as real values when reading from system DSN, and the driver manager ignores the actual values.